Attention is currently required from: DZ, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81835?usp=email )
Change subject: flashchips: Add support for MXIC MX25L1636E ......................................................................
Patch Set 1:
(3 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/81835/comment/7d13896d_1ae1a928 : PS1, Line 9283: OTP: 64B total I know it was like this before, but datasheets for both chips say 4k-bit secured OTP, so seems like it was wrong before. It should be 512B
https://review.coreboot.org/c/flashrom/+/81835/comment/45bf5729_a1dad53d : PS1, Line 9284: FEATURE_CFGR None of datasheets have configuration register?
https://review.coreboot.org/c/flashrom/+/81835/comment/052a50bd_5912daea : PS1, Line 9313: .tb = {CONFIG, 3, OTP} Same as above, none of datasheets have configuration register