Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59072 )
Change subject: [RFC][WPTST] dummyflasher: add SR2 emulation harness ......................................................................
Patch Set 12:
(3 comments)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/59072/comment/ea9c0f0f_75e347b1 PS12, Line 45: uint8_t emu_status; : uint8_t emu_status2; Can these be an array? i.e. `uint8_t emu_status[2];`
https://review.coreboot.org/c/flashrom/+/59072/comment/027c37f9_06dd093b PS12, Line 164: int Can we use `enum flash_reg` to represent the register?
Also maybe add _mask to the function's name, i.e. `get_status_ro_bit_mask()`
https://review.coreboot.org/c/flashrom/+/59072/comment/cd392bc0_68aacf0b PS12, Line 337: if (writecnt == 3) { I think this should check a flag in emu_data to check if the supports extended WRSR instructions.
-
Nikolai Artemiev (Code Review)