Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk.

View Change

3 comments:

• File dummyflasher.c:

  • Patch Set #12, Line 45:

    uint8_t emu_status;
    	uint8_t emu_status2;
    

    Can these be an array? i.e. `uint8_t emu_status[2];`

  • Patch Set #12, Line 164: int

    Can we use `enum flash_reg` to represent the register?

    Also maybe add _mask to the function's name, i.e. `get_status_ro_bit_mask()`

  • Patch Set #12, Line 337: if (writecnt == 3) {

    I think this should check a flag in emu_data to check if the supports extended WRSR instructions.

To view, visit change 59072. To unsubscribe, or for help writing mail filters, visit settings.