HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33344
Change subject: dmi.c: Remove unneeded 'else' ......................................................................
dmi.c: Remove unneeded 'else'
'else' is not needed after a 'break' or 'return'.
Change-Id: I71ab1fec98c2b61d73aeb646ddfc810662d4136d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M dmi.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/33344/1
diff --git a/dmi.c b/dmi.c index 79321ce..c32a8da 100644 --- a/dmi.c +++ b/dmi.c @@ -320,9 +320,8 @@ msg_perr("DMI pipe read error\n"); pclose(dmidecode_pipe); return NULL; - } else { - answerbuf[0] = 0; /* Hit EOF */ } + answerbuf[0] = 0; /* Hit EOF */ } } while (answerbuf[0] == '#');
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33344 )
Change subject: dmi.c: Remove unneeded 'else' ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33344 )
Change subject: dmi.c: Remove unneeded 'else' ......................................................................
dmi.c: Remove unneeded 'else'
'else' is not needed after a 'break' or 'return'.
Change-Id: I71ab1fec98c2b61d73aeb646ddfc810662d4136d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/flashrom/+/33344 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M dmi.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/dmi.c b/dmi.c index 79321ce..c32a8da 100644 --- a/dmi.c +++ b/dmi.c @@ -320,9 +320,8 @@ msg_perr("DMI pipe read error\n"); pclose(dmidecode_pipe); return NULL; - } else { - answerbuf[0] = 0; /* Hit EOF */ } + answerbuf[0] = 0; /* Hit EOF */ } } while (answerbuf[0] == '#');