Nico Huber merged this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
dmi.c: Remove unneeded 'else'

'else' is not needed after a 'break' or 'return'.

Change-Id: I71ab1fec98c2b61d73aeb646ddfc810662d4136d
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/33344
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M dmi.c
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dmi.c b/dmi.c
index 79321ce..c32a8da 100644
--- a/dmi.c
+++ b/dmi.c
@@ -320,9 +320,8 @@
msg_perr("DMI pipe read error\n");
pclose(dmidecode_pipe);
return NULL;
- } else {
- answerbuf[0] = 0; /* Hit EOF */
}
+ answerbuf[0] = 0; /* Hit EOF */
}
} while (answerbuf[0] == '#');


To view, visit change 33344. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71ab1fec98c2b61d73aeb646ddfc810662d4136d
Gerrit-Change-Number: 33344
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged