Nico Huber has posted comments on this change. ( https://review.coreboot.org/28086 )
Change subject: helpers: Add reverse_byte() and reverse_bytes() ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/28086/1/flash.h File flash.h:
https://review.coreboot.org/#/c/28086/1/flash.h@299 PS1, Line 299: void reverse_bytes(uint8_t *dst, const uint8_t *src, size_t length); Memory is returning. I think my argument was that we're changing the order of bits not bytes. Ofc, we can't name both functions `reverse_bits`... my current choice would be:
uint8_t reverse_bits(uint8_t); void reverse_bits_copy(uint8_t *, const uint8_t *, size_t);
But I won't fight it, if you want to keep the current names.