Patch set 1:Code-Review +2

View Change

1 comment:

• File flash.h:

  • Patch Set #1, Line 299: void reverse_bytes(uint8_t *dst, const uint8_t *src, size_t length);

    Memory is returning. I think my argument was that we're changing
    the order of bits not bytes. Ofc, we can't name both functions
    `reverse_bits`... my current choice would be:

      uint8_t reverse_bits(uint8_t);
      void reverse_bits_copy(uint8_t *, const uint8_t *, size_t);

    But I won't fight it, if you want to keep the current names.

To view, visit change 28086. To unsubscribe, or for help writing mail filters, visit settings.