Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69842 )
Change subject: opaque_master: Mark Opaque chip as tested for WP ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69842/comment/a5e426e2_130b303d PS1, Line 9: Opaque masters by design are populating information about a flashchip : on the runtime inside their probe function. I had a hard time parsing this. I think you mean to say:
"Opaque masters, by design, populate the flashchip structure during the execution of their probe function."
https://review.coreboot.org/c/flashrom/+/69842/comment/878e82cb_59b47233 PS1, Line 10: For the user the chip : is visible as "Opaque flash chip". delete.
https://review.coreboot.org/c/flashrom/+/69842/comment/1f30af4e_da8b3f3c PS1, Line 11: Without this patch, any operation : on opaque flash chip "Therefore any opaque master operation"
https://review.coreboot.org/c/flashrom/+/69842/comment/fca0c355_1d27e618 PS1, Line 13: and advises : to report on the mailing list. However, this is not very useful in : the case of Opaque chip. : delete and stop sentence here "."
https://review.coreboot.org/c/flashrom/+/69842/comment/634caffe_a53fd797 PS1, Line 17: For "However, for"
https://review.coreboot.org/c/flashrom/+/69842/comment/ac94eff6_5511756f PS1, Line 18: So it seems in line with opaque design : to mark WP as tested too. "Thus, align WP as marked tested inline with other opaque chip operations."
-
Edward O'Callaghan (Code Review)