Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk.

View Change

6 comments:

• Commit Message:

  • Patch Set #1, Line 9:

    Opaque masters by design are populating information about a flashchip
    on the runtime inside their probe function.
    

    I had a hard time parsing this. I think you mean to say:

    "Opaque masters, by design, populate the flashchip structure during the execution of their probe function."

  • Patch Set #1, Line 10:

    For the user the chip
    is visible as "Opaque flash chip".
    

    delete.

  • Patch Set #1, Line 11:

    Without this patch, any operation
    on opaque flash chip
    

    "Therefore any opaque master operation"

  • Patch Set #1, Line 13:

     and advises
    to report on the mailing list. However, this is not very useful in
    the case of Opaque chip.
    
    

    delete and stop sentence here "."

  • Patch Set #1, Line 17: For

    "However, for"

  • Patch Set #1, Line 18:

    So it seems in line with opaque design
    to mark WP as tested too.
    

    "Thus, align WP as marked tested inline with other opaque chip operations."

To view, visit change 69842. To unsubscribe, or for help writing mail filters, visit settings.