Attention is currently required from: qianfan, Nicholas Chin, Angel Pons.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70529 )
Change subject: Add initial CH347T SPI programmer ......................................................................
Patch Set 5:
(4 comments)
File ch347t_spi.c:
https://review.coreboot.org/c/flashrom/+/70529/comment/ca704c2c_a8d4666c PS5, Line 94: typedef uint32_t __le32; Why the typedefs?
https://review.coreboot.org/c/flashrom/+/70529/comment/699d3264_064dd323 PS5, Line 110: } __attribute__((packed)); This doesn't seem to be portable.
https://review.coreboot.org/c/flashrom/+/70529/comment/f4213933_f6424ca9 PS5, Line 169: if (n > CH347_MAX_DATA_WRITE) : n = CH347_MAX_DATA_WRITE; This doesn't seem to be a good idea...
https://review.coreboot.org/c/flashrom/+/70529/comment/402d8dca_bf63b31c PS5, Line 279: memset(&csctrl, 0, sizeof(csctrl)); Why not use an initialiser?
struct ch347_spi_csctrl_param csctrl = { 0 };