Attention is currently required from: qianfan, Nicholas Chin, Angel Pons.

View Change

4 comments:

• File ch347t_spi.c:

  • Patch Set #5, Line 94: typedef uint32_t __le32;

    Why the typedefs?

  • Patch Set #5, Line 110: } __attribute__((packed));

    This doesn't seem to be portable.

  • Patch Set #5, Line 169:

    if (n > CH347_MAX_DATA_WRITE)
    			n = CH347_MAX_DATA_WRITE;
    

    This doesn't seem to be a good idea...

  • Patch Set #5, Line 279: memset(&csctrl, 0, sizeof(csctrl));

    Why not use an initialiser?

     struct ch347_spi_csctrl_param csctrl = { 0 };

To view, visit change 70529. To unsubscribe, or for help writing mail filters, visit settings.