Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59742 )
Change subject: tests: Upgrade linux_spi test to run probe lifecycle ......................................................................
Patch Set 4:
(2 comments)
This change is ready for review.
File tests/lifecycle.c:
https://review.coreboot.org/c/flashrom/+/59742/comment/9ec1c5db_a45d242e PS2, Line 336: W25Q128.V
Thank you so much for finding the problem! I missed the elephant in the room, forgot about caching I […]
I fixed my epic fail :) I only have a question about spidev include (I added another comment).
File tests/lifecycle.c:
https://review.coreboot.org/c/flashrom/+/59742/comment/d61d5041_72f0f817 PS4, Line 18: #include <linux/spi/spidev.h> This include seems inevitable... is it ok? Do I need to guard it with anything? (like CONFIG_LINUX_SPI for example)
-
Anastasia Klimchuk (Code Review)