Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
View Change
2 comments:
File tests/lifecycle.c:
Patch Set #2, Line 336: W25Q128.V
Thank you so much for finding the problem! I missed the elephant in the room, forgot about caching I […]
I fixed my epic fail :) I only have a question about spidev include (I added another comment).
File tests/lifecycle.c:
Patch Set #4, Line 18: #include <linux/spi/spidev.h>
This include seems inevitable... is it ok? Do I need to guard it with anything? (like CONFIG_LINUX_SPI for example)
To view, visit change 59742. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I32d8e972d99b52c2b18f688aa6aeae75dd170f72
Gerrit-Change-Number: 59742
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Wed, 19 Jan 2022 03:23:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment