Change in ...flashrom[master]: dediprog: Use 4BA page program without 0x12

[David Hendricks (Code Review)]

David Hendricks has uploaded this change for review. (
https://review.coreboot.org/c/flashrom/+/30521


Change subject: dediprog: Use 4BA page program without 0x12
......................................................................

dediprog: Use 4BA page program without 0x12

It's not clear exactly what the difference is between
WRITE_MODE_4B_ADDR_256B_PAGE_PGM with and without _0x12 from the SF600
command spec, but the former seems to work more reliably.

Tested using an SF600 (FW v7.2.21), IS25LP256D, W25Q256JV, and
MX25L25735.

Change-Id: I3cb37ec8838f5bb02948ed52b4a2906fa033cf83
Signed-off-by: David Hendricks <david.hendricks(a)gmail.com>
---
M dediprog.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/30521/1

diff --git a/dediprog.c b/dediprog.c
index 2a190d2..303f1d5 100644
--- a/dediprog.c
+++ b/dediprog.c
@@ -398,7 +398,8 @@
 			}
 		} else if (dedi_spi_cmd == WRITE_MODE_PAGE_PGM) {
 			if (flash->chip->feature_bits & FEATURE_4BA_WRITE) {
-				data_packet[3] = WRITE_MODE_4B_ADDR_256B_PAGE_PGM_0x12;
+//				data_packet[3] = WRITE_MODE_4B_ADDR_256B_PAGE_PGM_0x12;
+				data_packet[3] = WRITE_MODE_4B_ADDR_256B_PAGE_PGM;
 				data_packet[4] = JEDEC_BYTE_PROGRAM_4BA;
 				use_4ba = true;
 			} else if (flash->in_4ba_mode) {

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/30521
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3cb37ec8838f5bb02948ed52b4a2906fa033cf83
Gerrit-Change-Number: 30521
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-MessageType: newchange

Change in flashrom[master]: dediprog: Use 4BA page program without 0x12

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. (
https://review.coreboot.org/c/flashrom/+/30521 )

Change subject: dediprog: Use 4BA page program without 0x12
......................................................................


Patch Set 2: -Code-Review

Seemed to help when testing with W25Q256JWFM + SF600 with firmware 7.2.21


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/30521
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3cb37ec8838f5bb02948ed52b4a2906fa033cf83
Gerrit-Change-Number: 30521
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 25 Aug 2020 17:02:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment