Attention is currently required from: Anastasia Klimchuk.
Sergii Dmytruk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84439?usp=email )
Change subject: Display progress for what is actually erased/written ......................................................................
Patch Set 13:
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/84439/comment/e78fc27d_c57d566f?usp... : PS13, Line 1270: // FIXME: round up to granularity?
It is a bit odd that `get_next_write` returns len, but `need_erase` returns 0 or 1, it would be cool […]
I think `get_next_write` limits length to not try to suggest writing more data then there is. There is no such data for erasing.
I think it can be deal with when cases of incorrect progress reporting surface. I'm not even sure that looping over pages here was the right choice.
https://review.coreboot.org/c/flashrom/+/84439/comment/14199e27_2e4d1b07?usp... : PS13, Line 1281: // FIXME: should be rounded up to page size?
It seems to me, this level of details is what `get_next_write` should be taking care of. […]
It does take granularity into account so maybe it's fine as is, assuming that regions never cross boundary specified by chip granularity.
-
Sergii Dmytruk (Code Review)