Attention is currently required from: Anastasia Klimchuk.

View Change

2 comments:

• File flashrom.c:

  • Patch Set #13, Line 1270: // FIXME: round up to granularity?

    It is a bit odd that `get_next_write` returns len, but `need_erase` returns 0 or 1, it would be cool […]

    I think `get_next_write` limits length to not try to suggest writing more data then there is. There is no such data for erasing.

    I think it can be deal with when cases of incorrect progress reporting surface. I'm not even sure that looping over pages here was the right choice.

  • Patch Set #13, Line 1281: // FIXME: should be rounded up to page size?

    It seems to me, this level of details is what `get_next_write` should be taking care of. […]

    It does take granularity into account so maybe it's fine as is, assuming that regions never cross boundary specified by chip granularity.

To view, visit change 84439. To unsubscribe, or for help writing mail filters, visit settings.