Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60113 )
Change subject: physmap: renoame to hwaccess_physmap, create own header ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/60113/comment/436d8cbb_816addcd PS4, Line 9: Line up physmap with the other hwaccess related code. Oh, we could make it a hwaccess/ subdir of src/. No wait, there is still no src/.
Patchset:
PS4: Just one question.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/60113/comment/eede6cf9_963d730a PS4, Line 41: #if CONFIG_INTERNAL == 1 Why the guard and why only here? It's just function prototypes, they shouldn't need guarding. Or do I miss something?
-
Nico Huber (Code Review)