Attention is currently required from: Thomas Heijligen, Angel Pons.

Patch set 4:Code-Review +1

View Change

3 comments:

• Commit Message:

  • Patch Set #4, Line 9: Line up physmap with the other hwaccess related code.

    Oh, we could make it a hwaccess/ subdir of src/. No wait, there is
    still no src/.

• Patchset:

  • Patch Set #4:

    Just one question.

• File flashrom.c:

  • Patch Set #4, Line 41: #if CONFIG_INTERNAL == 1

    Why the guard and why only here? It's just function prototypes, they
    shouldn't need guarding. Or do I miss something?

To view, visit change 60113. To unsubscribe, or for help writing mail filters, visit settings.