Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/62761 )
Change subject: board_enable.c: Remove unnecessary assignment ......................................................................
board_enable.c: Remove unnecessary assignment
In function board_asus_p3b_f there were two consecutive lines which modified the value of variable b
// Do something with b
b=INB(0x80); b=INB(smbba);
//Do something with b
Since the value of b is not used after first assignment, remove the first assignment.
Change-Id: I7458b416a69fd5e2aa300ca49d1352b6074ad0bc Tested-by: Keith Hui buurin@gmail.com Signed-off-by: Aarya Chaumal aarya.chaumal@gmail.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/62761 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Anastasia Klimchuk aklm@chromium.org Reviewed-by: Keith Hui buurin@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M board_enable.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Keith Hui: Looks good to me, but someone else must approve Felix Singer: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved
diff --git a/board_enable.c b/board_enable.c index 300fecb..442db33 100644 --- a/board_enable.c +++ b/board_enable.c @@ -910,7 +910,7 @@ /* Wait until SMBus transaction is complete. */ b = 0x1; while (b & 0x01) { - b = INB(0x80); + INB(0x80); b = INB(smbba); }
10 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.