Change in flashrom[master]: libflashrom.c: Fix unintialized value passed to function

[Anastasia Klimchuk (Code Review)]

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/62725 )

Change subject: libflashrom.c: Fix unintialized value passed to function
......................................................................

libflashrom.c: Fix unintialized value passed to function

In function flash_layout_read_from_ifd variable chip_layout remains
uninitialized if prepare_flash_access returns false. This uninitialized
variable (which contains a garbage value) is passed to
flashrom_layout_release. Thus initialize it with NULL. For completeness,
also initialize dump_layout with NULL.

Change-Id: Iacbd7bf9cdf897cc2a732c1dc6568845a4ab804d
Signed-off-by: Aarya Chaumal <[e-mail]>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/62725
Reviewed-by: Felix Singer <[e-mail]>
Reviewed-by: Edward O'Callaghan <[e-mail]>
Reviewed-by: Nico Huber <[e-mail]>
Reviewed-by: Anastasia Klimchuk <[e-mail]>
Tested-by: build bot (Jenkins) <[e-mail]>
---
M libflashrom.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Felix Singer: Looks good to me, approved
  Edward O'Callaghan: Looks good to me, approved
  Anastasia Klimchuk: Looks good to me, approved



diff --git a/libflashrom.c b/libflashrom.c
index f2288fe..39b0c67 100644
--- a/libflashrom.c
+++ b/libflashrom.c
@@ -442,7 +442,7 @@
 #ifndef __FLASHROM_LITTLE_ENDIAN__
 	return 6;
 #else
-	struct flashrom_layout *dump_layout, *chip_layout;
+	struct flashrom_layout *dump_layout = NULL, *chip_layout = NULL;
 	int ret = 1;
 
 	void *const desc = malloc(0x1000);

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iacbd7bf9cdf897cc2a732c1dc6568845a4ab804d
Gerrit-Change-Number: 62725
Gerrit-PatchSet: 18
Gerrit-Owner: Light <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Felix Singer <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: merged