Attention is currently required from: Anastasia Klimchuk, Daniel Campello, Edward O'Callaghan, Nico Huber, Richard Hughes.
Peter Marheine has posted comments on this change by Richard Hughes. ( https://review.coreboot.org/c/flashrom/+/64663?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: libflashrom: Allow getting the progress_state from the flashctx
......................................................................
Patch Set 5:
(1 comment)
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/64663/comment/a9829e26_9bbb11df?usp... :
PS5, Line 108: struct flashrom_progress *flashrom_get_progress_state(struct flashrom_flashctx *flashctx);
I wonder if this should be a `const struct flashrom_progress*` to indicate that we don't expect the caller to modify the progress information? It wouldn't be harmful if they did (at least with the current implementation), but I think it would be better to exclude mutability completely.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64663?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010
Gerrit-Change-Number: 64663
Gerrit-PatchSet: 5
Gerrit-Owner: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Richard Hughes
richard@hughsie.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 12 Nov 2024 00:20:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No