Attention is currently required from: Anastasia Klimchuk, Daniel Campello, Edward O'Callaghan, Nico Huber, Richard Hughes.

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

View Change

1 comment:

• File include/libflashrom.h:

  • Patch Set #5, Line 108: struct flashrom_progress *flashrom_get_progress_state(struct flashrom_flashctx *flashctx);

    I wonder if this should be a `const struct flashrom_progress*` to indicate that we don't expect the caller to modify the progress information? It wouldn't be harmful if they did (at least with the current implementation), but I think it would be better to exclude mutability completely.

To view, visit change 64663. To unsubscribe, or for help writing mail filters, visit settings.