Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52497 )
Change subject: tests: Add unit test to run init/shutdown for dummyflasher.c ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52497/comment/42867ba1_28a359c3 PS2, Line 9: I plan to do this for all drivers in programmer table, : one at a time. Dummy is the first and it does not need : mocks. :
This explains a overarching strategy however is spare on the detail of the commit itself. […]
Done
https://review.coreboot.org/c/flashrom/+/52497/comment/787f0482_e11e0983 PS2, Line 13: After this was rebased on the top of memory checks : https://review.coreboot.org/c/flashrom/+/51243 , : dummy has been discovered to leak memory on shutdown, : so I fix it here.
separate patch as it is not related to the introduction of the test code itself just that a previous […]
Done
Patchset:
PS3: thanks for review!
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/52497/comment/78d912b3_8aac47ad PS2, Line 653: free(data);
Fix the memory leak in a separate patch as not to be conflated with the introduction of test code. […]
Done