Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

4 comments:

• Commit Message:

  • Patch Set #2, Line 9:

    I plan to do this for all drivers in programmer table,
    one at a time. Dummy is the first and it does not need
    mocks.
    
    

    This explains a overarching strategy however is spare on the detail of the commit itself. […]

    Done

  • Patch Set #2, Line 13:

    After this was rebased on the top of memory checks
    https://review.coreboot.org/c/flashrom/+/51243 ,
    dummy has been discovered to leak memory on shutdown,
    so I fix it here.
    

    separate patch as it is not related to the introduction of the test code itself just that a previous […]

    Done

• Patchset:

  • Patch Set #3:

    thanks for review!

• File dummyflasher.c:

  • Patch Set #2, Line 653: free(data);

    Fix the memory leak in a separate patch as not to be conflated with the introduction of test code. […]

    Done

To view, visit change 52497. To unsubscribe, or for help writing mail filters, visit settings.