Attention is currently required from: Anastasia Klimchuk, David Wu, Kapil Porwal, Lean Sheng Tan, Nikolai Artemiev, Tyler Wang.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79460?usp=email )
Change subject: flashchips: Add write-protect support for GD25LQ255E
......................................................................
Patch Set 5:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/79460/comment/465ba6b8_a4cebec1 :
PS5, Line 6559: FEATURE_WRSR2
So if I understand it correctly, (1) we shouldn't add `FEATURE_WRSR2` here (2) But it is okay since […]
Oh no I were wrong... it has a break, this means you can pass with the config `FEATURE_WRSR2` and invoke command (31H) which is not listed on the datasheet... This sounds very weird to me.
But we should stick to what datasheet told us, which is using `FEATURE_WRSR_EXT2` only.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/79460?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I1425e931433c00caceaabc6037a79099d6d5eac5
Gerrit-Change-Number: 79460
Gerrit-PatchSet: 5
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Wed, 27 Dec 2023 08:58:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com
Gerrit-MessageType: comment