[S] Change in flashrom[main]: flashchips: Add write-protect support for GD25LQ255E

[Hsuan-ting Chen (Code Review)]

Attention is currently required from: Anastasia Klimchuk, David Wu, Kapil Porwal, Lean Sheng Tan, Nikolai Artemiev, Tyler Wang.

Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79460?usp=email )

Change subject: flashchips: Add write-protect support for GD25LQ255E
......................................................................


Patch Set 5:

(1 comment)

File flashchips.c:

https://review.coreboot.org/c/flashrom/+/79460/comment/465ba6b8_a4cebec1 :
PS5, Line 6559: FEATURE_WRSR2
> So if I understand it correctly, (1) we shouldn't add `FEATURE_WRSR2` here (2) But it is okay since  […]
> Oh no I were wrong... it has a break, this means you can pass with the config `FEATURE_WRSR2` and invoke command (31H) which is not listed on the datasheet... This sounds very weird to me.

But we should stick to what datasheet told us, which is using `FEATURE_WRSR_EXT2` only.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/79460?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I1425e931433c00caceaabc6037a79099d6d5eac5
Gerrit-Change-Number: 79460
Gerrit-PatchSet: 5
Gerrit-Owner: Tyler Wang <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: David Wu <[e-mail]>
Gerrit-Reviewer: Hsuan-ting Chen <[e-mail]>
Gerrit-Reviewer: Kapil Porwal <[e-mail]>
Gerrit-Reviewer: Lean Sheng Tan <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: Stefan Reinauer <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Subrata Banik <[e-mail]>
Gerrit-Attention: David Wu <[e-mail]>
Gerrit-Attention: Kapil Porwal <[e-mail]>
Gerrit-Attention: Tyler Wang <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Attention: Lean Sheng Tan <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-Comment-Date: Wed, 27 Dec 2023 08:58:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen <[e-mail]>
Gerrit-MessageType: comment