Attention is currently required from: Drew Fustini, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51113 )
Change subject: Add support for GD25LQ256D ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
Patchset:
PS1: As the datasheet seems incomplete wrt. 4-byte addressing, it would be nice to leave a TODO comment about that. Also, please upload a verbose log of a write (with changed data) run to `paste.flashrom.org`.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/51113/comment/8ef9c63b_bcf769e9 PS1, Line 6719: UNTESTED You can update this to PREW.
https://review.coreboot.org/c/flashrom/+/51113/comment/fb174837_aece195a PS1, Line 6726: .block_erase = spi_block_erase_21, This (and the other 4-byte address commands) is not mentioned in the datasheet (rev. 2.0 I found). If flashrom didn't complain, it seems supported, though.
-
Nico Huber (Code Review)