Attention is currently required from: Drew Fustini. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51113 )
Change subject: Add support for GD25LQ256D ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/51113/comment/b601db2c_1ae6cf94 PS1, Line 6718: .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_ENTER, Missing FEATURE_QPI?
https://review.coreboot.org/c/flashrom/+/51113/comment/3795c395_87728745 PS1, Line 6750: spi_prettyprint_status_register_bp3_srwd According to the datasheet, this should be `spi_prettyprint_status_register_bp4_srwd` instead.
https://review.coreboot.org/c/flashrom/+/51113/comment/7654655c_ec5e0ef9 PS1, Line 6751: spi_disable_blockprotect spi_disable_blockprotect_bp4_srwd
https://review.coreboot.org/c/flashrom/+/51113/comment/44655ee3_6fe0cd8f PS1, Line 6757: nit: one blank line is enough here
-
Angel Pons (Code Review)