Attention is currently required from: Felix Singer, Edward O'Callaghan.
Alex Badea has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73037 )
Change subject: asm106x: add programmer for ASM106x SATA controllers ......................................................................
Patch Set 9:
(8 comments)
File asm106x.c:
https://review.coreboot.org/c/flashrom/+/73037/comment/7282189c_97b95bee PS7, Line 76: u
const
Done
https://review.coreboot.org/c/flashrom/+/73037/comment/0a4dafa3_20551d2b PS7, Line 79: int
unsigned int?
The last iteration would go below zero, and if unsigned would wrap around.
https://review.coreboot.org/c/flashrom/+/73037/comment/bad1a2f2_eee5d5ee PS7, Line 91: u
const
Done
https://review.coreboot.org/c/flashrom/+/73037/comment/5add47cd_16092db2 PS7, Line 92: uint32_t val;
drop forward decl
Done
https://review.coreboot.org/c/flashrom/+/73037/comment/2677d0a4_750f5fef PS7, Line 98: v
uint32_t val = ..
Done
https://review.coreboot.org/c/flashrom/+/73037/comment/dd52462a_c337014a PS7, Line 100: unsigned
unsigned int
Done
https://review.coreboot.org/c/flashrom/+/73037/comment/c59244a1_212bafca PS7, Line 129: .write_aai = default_spi_write_aai,
delete.
Done
https://review.coreboot.org/c/flashrom/+/73037/comment/82d14c51_15c35ddb PS7, Line 149: (void *)
cast shouldn't be required?
Done
-
Alex Badea (Code Review)