Attention is currently required from: Felix Singer, Edward O'Callaghan.

View Change

8 comments:

• File asm106x.c:

  • Patch Set #7, Line 76: u

    const

    Done

  • Patch Set #7, Line 79: int

    unsigned int?

    The last iteration would go below zero, and if unsigned would wrap around.

  • Patch Set #7, Line 91: u

    const

    Done

  • Patch Set #7, Line 92: uint32_t val;

    drop forward decl

    Done

  • Patch Set #7, Line 98: v

    uint32_t val = ..

    Done

  • Patch Set #7, Line 100: unsigned

    unsigned int

    Done

  • Patch Set #7, Line 129: .write_aai = default_spi_write_aai,

    delete.

    Done

  • Patch Set #7, Line 149: (void *)

    cast shouldn't be required?

    Done

To view, visit change 73037. To unsubscribe, or for help writing mail filters, visit settings.