Nico Huber has posted comments on this change. ( https://review.coreboot.org/19187 )
Change subject: Make coreboot.org the upstream server ......................................................................
Patch Set 5:
(2 comments)
NVM, the change to the upstream_pattern makes sense.
https://review.coreboot.org/#/c/19187/5/util/getrevision.sh File util/getrevision.sh:
https://review.coreboot.org/#/c/19187/5/util/getrevision.sh@35 PS5, Line 35: upstream_url="https://review.coreboot.org/flashrom.git" This is unnecessary, I guess.
https://review.coreboot.org/#/c/19187/5/util/getrevision.sh@36 PS5, Line 36: upstream_patterns="github.com.flashrom/flashrom(.git)?|flashrom.org.git/flashrom(.git)?|coreboot.org.*/flashrom(.git)?" I agree here.
The pattern could be condensed though, it always ends in `/flashrom(.git)?`.