Nico Huber posted comments on this change.

View Change

Patch set 5:

NVM, the change to the upstream_pattern makes sense.

(2 comments)

• File util/getrevision.sh:

  • Patch Set #5, Line 35: upstream_url="https://review.coreboot.org/flashrom.git"

    This is unnecessary, I guess.

  • Patch Set #5, Line 36: upstream_patterns="github\.com.flashrom/flashrom(\.git)?|flashrom\.org.git/flashrom(\.git)?|coreboot\.org.*/flashrom(\.git)?"

    I agree here.

    The pattern could be condensed though, it always ends in `/flashrom(\.git)?`.

To view, visit change 19187. To unsubscribe, visit settings.