Change in flashrom[master]: ft2232_spi.c - Pack WREN and op in one ftdi_write_data() call to save...

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )

Change subject: ft2232_spi.c - Pack WREN and op in one ftdi_write_data() call to save programming time
......................................................................

Patch Set 2:

(4 comments)

https://review.coreboot.org/c/flashrom/+/40477/2/ft2232_spi.c 
File ft2232_spi.c:

https://review.coreboot.org/c/flashrom/+/40477/2/ft2232_spi.c@473 
PS2, Line 473:     
tab for consistency

https://review.coreboot.org/c/flashrom/+/40477/2/ft2232_spi.c@482 
PS2, Line 482:     /* 280 Byte = (9 Byte CMD + 1 Byte WREN) + (9 Byte CMD + 1 Byte op) + 4 Byte Addr + 256 Byte PageWrite-data
wrap differently so it fits on 80 columns? (also in line 548)

https://review.coreboot.org/c/flashrom/+/40477/2/ft2232_spi.c@546 
PS2, Line 546:     
no trailing white space (also elsewhere)

https://review.coreboot.org/c/flashrom/+/40477/2/ft2232_spi.c@549 
PS2, Line 549: 		return 0;   
so you're filling in buf, then leaving it hanging and somehow that data re-appears on the next run. Is that based on an assumption that realloc will point to the same memory range? Seems scary!