View Change

4 comments:

• File ft2232_spi.c:

  • Patch Set #2, Line 473:

    tab for consistency

  • Patch Set #2, Line 482: /* 280 Byte = (9 Byte CMD + 1 Byte WREN) + (9 Byte CMD + 1 Byte op) + 4 Byte Addr + 256 Byte PageWrite-data

    wrap differently so it fits on 80 columns? (also in line 548)

  • Patch Set #2, Line 546:

    no trailing white space (also elsewhere)

  • Patch Set #2, Line 549: return 0;

    so you're filling in buf, then leaving it hanging and somehow that data re-appears on the next run. Is that based on an assumption that realloc will point to the same memory range? Seems scary!

To view, visit change 40477. To unsubscribe, or for help writing mail filters, visit settings.