Change in flashrom[master]: meson: relocate config_print_wiki & config_default_programmer_*
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64029 )
Change subject: meson: relocate config_print_wiki & config_default_programmer_* ......................................................................
Patch Set 3:
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/64029/comment/f4ce1f7c_80bb6ab8 PS2, Line 417: cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"'
Shouldn't this line be under if condition too? There is no need for default programmer args if defau […]
CONFIG_DEFAULT_PROGRAMMER_ARGS must be defined, at least as an empty string. classic_cli.c:838
I would prefer to drop the default programmer to have a unified behavior across all flashrom builds. Do you think that would be good?
-
Thomas Heijligen (Code Review)