View Change

1 comment:

• File meson.build:

  • Patch Set #2, Line 417: cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"'

    Shouldn't this line be under if condition too? There is no need for default programmer args if defau […]

    CONFIG_DEFAULT_PROGRAMMER_ARGS must be defined, at least as an empty string.
    classic_cli.c:838

    I would prefer to drop the default programmer to have a unified behavior across all flashrom builds. Do you think that would be good?

To view, visit change 64029. To unsubscribe, or for help writing mail filters, visit settings.