Attention is currently required from: Angel Pons, Artur Kowalski.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68557?usp=email )
Change subject: flashchips: add support for MX77L25650F chip ......................................................................
Patch Set 4:
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68557/comment/c7672f59_a6e1c65f : PS1, Line 7: flashrom
fixed
Done
https://review.coreboot.org/c/flashrom/+/68557/comment/7bf88b33_d2bfaa1c : PS1, Line 9: read and write
Erasing was done before writing and it worked properly, updated commit message accordingly
Done
Commit Message:
https://review.coreboot.org/c/flashrom/+/68557/comment/60b27d08_6dbdeddf : PS4, Line 11: can't disable it can't enable it (that's what seems to be the case from commit message?)
Patchset:
PS4: Artur sorry this patch got delayed! I hope you are still here and have some time to finish remaining comments? I marked as resolved the comments which are seem to be resolved. Thank you!
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/68557/comment/6ea6ae72_c0a64cbf : PS1, Line 10215: // TODO: add 64K block erase
Added 64K block erase
Done
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/68557/comment/207b30fc_eb74b78c : PS4, Line 10449: // TODO: add support for flash protection I don't think we need this TODO is the code. If you don't plan to add support for write protect, better to remove the TODO. But I understand the patch is sitting for a while, maybe the situation has changed and you can add wp support now? Either way, you don't need a TODO.
-
Anastasia Klimchuk (Code Review)