[L] Change in flashrom[main]: libflashrom: Add probing v2 which can find all matching chips

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Dmitry Zhadinets, Peter Marheine.

Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/87341?usp=email )

Change subject: libflashrom: Add probing v2 which can find all matching chips
......................................................................

Patch Set 8:

(6 comments)

Patchset:

PS8: 
thanks so much for review!

Commit Message:

https://review.coreboot.org/c/flashrom/+/87341/comment/c1cf234e_c191df28?usp... :
PS7, Line 7: mathching
> typo […]

Done

File cli_classic.c:

https://review.coreboot.org/c/flashrom/+/87341/comment/6a834246_1a691d26?usp... :
PS7, Line 1056: 	const char *** const all_matched_names = malloc(sizeof(char***));
> There's no reason to dynamically allocate this pointer, just pass a pointer to a `const char **` int […]

Done

File include/libflashrom.h:

https://review.coreboot.org/c/flashrom/+/87341/comment/0a327f65_ac019109?usp... :
PS7, Line 294: needs to be freed with flashrom_data_free
             :  * afterwards.
> Does the caller also need to free the buffer if an error is returned?

I think yes, I added this to documentation. Since it's allocated in the very beginning.

https://review.coreboot.org/c/flashrom/+/87341/comment/1abb2db2_417c581a?usp... :
PS7, Line 306: pointer to the empty list if no chips found.
> Define what an empty list is: I think this is using NULL as a sentinel but the documentation should  […]

Done

File libflashrom.c:

https://review.coreboot.org/c/flashrom/+/87341/comment/fa28b1fb_d1025fcc?usp... :
PS7, Line 395: 0
> Use NULL here so it's obvious this is a pointer.

Done