Attention is currently required from: Dmitry Zhadinets, Peter Marheine.

View Change

6 comments:

• Patchset:

  • Patch Set #8:

    thanks so much for review!

• Commit Message:

  • Patch Set #7, Line 7: mathching

    typo […]

    Done

• File cli_classic.c:

  • Patch Set #7, Line 1056: const char *** const all_matched_names = malloc(sizeof(char***));

    There's no reason to dynamically allocate this pointer, just pass a pointer to a `const char **` int […]

    Done

• File include/libflashrom.h:

  • Patch Set #7, Line 294:

    needs to be freed with flashrom_data_free
     * afterwards.
    

    Does the caller also need to free the buffer if an error is returned?

    I think yes, I added this to documentation. Since it's allocated in the very beginning.

  • Patch Set #7, Line 306: pointer to the empty list if no chips found.

    Define what an empty list is: I think this is using NULL as a sentinel but the documentation should […]

    Done

• File libflashrom.c:

  • Patch Set #7, Line 395: 0

    Use NULL here so it's obvious this is a pointer.

    Done

To view, visit change 87341. To unsubscribe, or for help writing mail filters, visit settings.