Change in flashrom[master]: 82802ab.c: Remove duplicated check

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/38661 )

Change subject: 82802ab.c: Remove duplicated check
......................................................................

82802ab.c: Remove duplicated check

Change-Id: I5d511d7ec254bdbd9926e6d8efc308fb2339cb81
Signed-off-by: Angel Pons 
---
M 82802ab.c
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/38661/1

diff --git a/82802ab.c b/82802ab.c
index a44a66e..a13a4a0 100644
--- a/82802ab.c
+++ b/82802ab.c
@@ -89,9 +89,9 @@
    chipaddr bios = flash->virtual_memory;

chip_writeb(flash, 0x70, bios);
-	if ((chip_readb(flash, bios) & 0x80) == 0) {	/* it's busy */
-		while ((chip_readb(flash, bios) & 0x80) == 0) ;
-	}
+
+	while ((chip_readb(flash, bios) & 0x80) == 0)	/* it's busy */
+		;

status = chip_readb(flash, bios);

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38661 )

Change subject: 82802ab.c: Remove duplicated check
......................................................................

Patch Set 1: Code-Review+2

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38661 )

Change subject: 82802ab.c: Remove duplicated check
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Hello Edward O'Callaghan, David Hendricks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/38661

to look at the new patch set (#2).

Change subject: 82802ab.c: Remove duplicated check
......................................................................

82802ab.c: Remove duplicated check

Change-Id: I5d511d7ec254bdbd9926e6d8efc308fb2339cb81
Signed-off-by: Angel Pons 
---
M 82802ab.c
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/38661/2

[Philippe Mathieu-Daudé (Code Review)]

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38661 )

Change subject: 82802ab.c: Remove duplicated check
......................................................................

Patch Set 2: Code-Review+1

Typo in description: "Remove duplicate check"

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38661 )

Change subject: 82802ab.c: Remove duplicated check
......................................................................

Patch Set 2:
> Patch Set 2: Code-Review+1
>
> Typo in description: "Remove duplicate check"

"duplicated" is the past participle form of "duplicate", and it's functioning as an adjective. It isn't a typo. The meaning is equivalent to that of "Remove check that is duplicated".

[Idwer Vollering (Code Review)]

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38661 )

Change subject: 82802ab.c: Remove duplicated check
......................................................................

Patch Set 3:

FYI this has been there since 2002 (when this tool was named flash_and_burn): https://github.com/flashrom/flashrom/commit/56439427500146bf125b081406275be5...

[Idwer Vollering (Code Review)]

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38661 )

Change subject: 82802ab.c: Remove duplicated check
......................................................................

Patch Set 3: Code-Review+2

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38661 )

Change subject: 82802ab.c: Remove duplicated check
......................................................................

Patch Set 3: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/38661 )

Change subject: 82802ab.c: Remove duplicated check
......................................................................

82802ab.c: Remove duplicated check

Change-Id: I5d511d7ec254bdbd9926e6d8efc308fb2339cb81
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/38661
Reviewed-by: Idwer Vollering 
Reviewed-by: Edward O'Callaghan 
Reviewed-by: Philippe Mathieu-Daudé 
Tested-by: build bot (Jenkins) 
---
M 82802ab.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Idwer Vollering: Looks good to me, approved
  Philippe Mathieu-Daudé: Looks good to me, but someone else must approve
  Edward O'Callaghan: Looks good to me, approved

diff --git a/82802ab.c b/82802ab.c
index 281b66e..b485c11 100644
--- a/82802ab.c
+++ b/82802ab.c
@@ -89,9 +89,9 @@
    chipaddr bios = flash->virtual_memory;

chip_writeb(flash, 0x70, bios);
-	if ((chip_readb(flash, bios) & 0x80) == 0) {	// it's busy
-		while ((chip_readb(flash, bios) & 0x80) == 0) ;
-	}
+
+	while ((chip_readb(flash, bios) & 0x80) == 0)	// it's busy
+		;

status = chip_readb(flash, bios);