Angel Pons submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Idwer Vollering: Looks good to me, approved Philippe Mathieu-Daudé: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved
82802ab.c: Remove duplicated check

Change-Id: I5d511d7ec254bdbd9926e6d8efc308fb2339cb81
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/38661
Reviewed-by: Idwer Vollering <vidwer@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M 82802ab.c
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/82802ab.c b/82802ab.c
index 281b66e..b485c11 100644
--- a/82802ab.c
+++ b/82802ab.c
@@ -89,9 +89,9 @@
chipaddr bios = flash->virtual_memory;

chip_writeb(flash, 0x70, bios);
- if ((chip_readb(flash, bios) & 0x80) == 0) { // it's busy
- while ((chip_readb(flash, bios) & 0x80) == 0) ;
- }
+
+ while ((chip_readb(flash, bios) & 0x80) == 0) // it's busy
+ ;

status = chip_readb(flash, bios);


To view, visit change 38661. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5d511d7ec254bdbd9926e6d8efc308fb2339cb81
Gerrit-Change-Number: 38661
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Idwer Vollering <vidwer@gmail.com>
Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug@amsat.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged