Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Alexander Goncharov.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73361 )
Change subject: meson: revert to meson version 0.53.0 ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/73361/comment/da546866_923be864 PS1, Line 9: 0.63.2
Typo. https://packages.debian.org/bullseye/meson says about meson 0.56. […]
Thanks for spotting.
https://review.coreboot.org/c/flashrom/+/73361/comment/726b5c92_98124394 PS1, Line 10: Pass arguments to `sphinx-doc` via `'-Dkey=value`
I feel that I am missing something, but where this is in the patch?
In `doc/meson.build` where sphinx is called as custom_target.
Originally I used `FLASHROM_VERSION=meson.project_version()` in the environment of the custom_target and `os.getenv('FLASHROM_VERSION')` in `doc/conf.py` (the configuration of sphinx) to pass the version information.
Now I pass `-Drelease=meson.project_version()` as parameter of the `sphinx` call, which directly writes the `release` variable in sphinx.
From `sphinx-build`: ``` -D setting=value override a setting in configuration file ```
Is it now better to understand? Should I put this comment also in the commit message?
-
Thomas Heijligen (Code Review)