Attention is currently required from: Richard Hughes, Angel Pons, Patrick Rudolph. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 )
Change subject: libflashrom: Return progress state to the library user ......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49643/comment/c325d5b5_1fa33580 PS6, Line 9: Projects using libflashrom like fwupd expect the user to wait for the operation : to complete. To avoid the user thinking the process has "hung" or "got stuck" : report back the progress complete of the erase, write and read operations That's good, thank you! One thing left, limit for commit message lines is 72 chars, look like this one is over the limit and lines are broken.
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/49643/comment/aa2abe69_510ddc5a PS4, Line 106: void *
Is there a reason why last argument doesn't have a name here? all other arguments have names.
Done
File tests/spi25.c:
https://review.coreboot.org/c/flashrom/+/49643/comment/3e8f7ef7_67640bba PS4, Line 54: size_t current,
Thank you for the test! Is there any way to assert what current value is? it should change (unlike t […]
Done
-
Anastasia Klimchuk (Code Review)