Attention is currently required from: Richard Hughes, Angel Pons, Patrick Rudolph.

View Change

3 comments:

• Commit Message:

  • Patch Set #6, Line 9:

    Projects using libflashrom like fwupd expect the user to wait for the operation
    to complete. To avoid the user thinking the process has "hung" or "got stuck"
    report back the progress complete of the erase, write and read operations
    

    That's good, thank you! One thing left, limit for commit message lines is 72 chars, look like this one is over the limit and lines are broken.

• File libflashrom.h:

  • Patch Set #4, Line 106: void *

    Is there a reason why last argument doesn't have a name here? all other arguments have names.

    Done

• File tests/spi25.c:

  • Patch Set #4, Line 54: size_t current,

    Thank you for the test! Is there any way to assert what current value is? it should change (unlike t […]

    Done

To view, visit change 49643. To unsubscribe, or for help writing mail filters, visit settings.