Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52945 )
Change subject: programmer_table: convert entries to pointers ......................................................................
Patch Set 3: Code-Review+1
(9 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52945/comment/cd179915_e7594cab PS3, Line 8: Please mention:
Allows us to move the individual entries into their respective driver files.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/52945/comment/bd93d257_4500c665 PS3, Line 1721: const struct programmer_entry *p = programmer_table[i]; Please add a check `if (p == NULL)` right here.
https://review.coreboot.org/c/flashrom/+/52945/comment/c5bf717f_10cd2e44 PS3, Line 1721: *p Nit, could be `*const p`.
File print.c:
https://review.coreboot.org/c/flashrom/+/52945/comment/bb9443b3_4f575908 PS3, Line 428: *prog Nit, this could be `*const prog`.
https://review.coreboot.org/c/flashrom/+/52945/comment/f30ebdd5_0d9bb2c7 PS3, Line 486: *prog *const prog
File print_wiki.c:
https://review.coreboot.org/c/flashrom/+/52945/comment/66cbbfd8_9da968d1 PS3, Line 358: *prog *const prog
https://review.coreboot.org/c/flashrom/+/52945/comment/cb58b6a8_fae71833 PS3, Line 384: *prog ditto... and below
File programmer.h:
https://review.coreboot.org/c/flashrom/+/52945/comment/43ac4818_64252cdf PS3, Line 178: *programmer_table The pointers should be const, nobody should be allowed to change them at runtime, right?
*const programmer_table
File programmer_table.c:
https://review.coreboot.org/c/flashrom/+/52945/comment/252a9ae9_bb45d4ef PS3, Line 477: *programmer_table *const programmer_table
-
Nico Huber (Code Review)