Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

Patch set 3:Code-Review +1

View Change

9 comments:

• Commit Message:

  • Patch Set #3, Line 8:

    Please mention:

      Allows us to move the individual entries into their respective driver files.

• File flashrom.c:

  • Patch Set #3, Line 1721: const struct programmer_entry *p = programmer_table[i];

    Please add a check `if (p == NULL)` right here.

  • Patch Set #3, Line 1721: *p

    Nit, could be `*const p`.

• File print.c:

  • Patch Set #3, Line 428: *prog

    Nit, this could be `*const prog`.

  • Patch Set #3, Line 486: *prog

    *const prog

• File print_wiki.c:

  • Patch Set #3, Line 358: *prog

    *const prog

  • Patch Set #3, Line 384: *prog

    ditto... and below

• File programmer.h:

  • Patch Set #3, Line 178: *programmer_table

    The pointers should be const, nobody should be allowed to change them
    at runtime, right?

       *const programmer_table

• File programmer_table.c:

  • Patch Set #3, Line 477: *programmer_table

    *const programmer_table

To view, visit change 52945. To unsubscribe, or for help writing mail filters, visit settings.