[M] Change in flashrom[master]: rayer_spi.c: Roll up programmer type search logic into func
Attention is currently required from: Felix Singer, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68238 )
Change subject: rayer_spi.c: Roll up programmer type search logic into func ......................................................................
Patch Set 3:
(3 comments)
File rayer_spi.c:
https://review.coreboot.org/c/flashrom/+/68238/comment/77e20375_a4514f32 PS2, Line 271: static const struct rayer_programmer *find_progtype(const char *prog_type)
If you want to keep CB:68239 as a separate commit, could you please move this function above `get_pa […]
Done. Thank you for the future refinement of CB:68239 , looks much better after that.
https://review.coreboot.org/c/flashrom/+/68238/comment/abb67604_17318915 PS2, Line 274: NULL
No, this changes behavior. […]
Fixed, thanks for spotting this!.
https://review.coreboot.org/c/flashrom/+/68238/comment/3986ef86_998e2427 PS2, Line 276: const struct rayer_programmer rayer_spi_types[] = {
Shouldn't this be marked `static`? Not sure if it matters for constants, but if this were to be plac […]
Good question. I am not sure if this is actually required, I need to check the C spec again but I put `static` here for now just in case. Seems harmless if not strictly required.
-
Edward O'Callaghan (Code Review)