Attention is currently required from: Felix Singer, Angel Pons.

View Change

3 comments:

• File rayer_spi.c:

  • Patch Set #2, Line 271: static const struct rayer_programmer *find_progtype(const char *prog_type)

    If you want to keep CB:68239 as a separate commit, could you please move this function above `get_pa […]

    Done. Thank you for the future refinement of CB:68239 , looks much better after that.

  • Patch Set #2, Line 274: NULL

    No, this changes behavior. […]

    Fixed, thanks for spotting this!.

  • Patch Set #2, Line 276: const struct rayer_programmer rayer_spi_types[] = {

    Shouldn't this be marked `static`? Not sure if it matters for constants, but if this were to be plac […]

    Good question. I am not sure if this is actually required, I need to check the C spec again but I put `static` here for now just in case. Seems harmless if not strictly required.

To view, visit change 68238. To unsubscribe, or for help writing mail filters, visit settings.