Change in flashrom[master]: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops

[Michał Żygowski (Code Review)]

Attention is currently required from:  Felix Singer, Nico Huber, Angel Pons.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )

Change subject: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops
......................................................................

Patch Set 4:

(5 comments)

File flashrom.8.tmpl:

https://review.coreboot.org/c/flashrom/+/55715/comment/deae2c33_b4c6c0ad 
PS1, Line 648: .SS
> Was this removed on purpose?

No. Cleaned up this change.

File tuxedo_ec.c:

https://review.coreboot.org/c/flashrom/+/55715/comment/1ed61f58_9e677399 
PS1, Line 235: len % BYTES_PER_BLOCK != 0 && len < BYTES_PER_BLOCK
> It should be multiple of BYTES_PER_BLOCK

Done

https://review.coreboot.org/c/flashrom/+/55715/comment/af2ee5e5_b9dd583e 
PS1, Line 433: len % BYTES_PER_BLOCK != 0 && len < BYTES_PER_BLOCK
> Are you sure this check is supposed to use an AND? Shouldn't it be checking that the length is a mul […]

Done

https://review.coreboot.org/c/flashrom/+/55715/comment/51d2d727_792443b9 
PS1, Line 482: if (!ec_wait_for_obuf(ctx_data->control_port,
             : 				      EC_MAX_STATUS_CHECKS * 3))
             : 			return 1;
             : 
             : 		if (INB(ctx_data->data_port) == 0xf8)
             : 			return 0;
> Looks like this is open-coding `tuxedo_ec_read_byte` because the `max_checks` parameter isn't expose […]

Added max_checks to all ACPI EC API calls and removed this open-coding

https://review.coreboot.org/c/flashrom/+/55715/comment/888acbfc_f802615a 
PS1, Line 504: ++to_chunk
> The check below should prevent it. […]

Done