Attention is currently required from: Nicholas Chin.
ZhiYuanNJ has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82776?usp=email )
Change subject: ch347_spi: Add spi clock frequency selection ......................................................................
Patch Set 5:
(7 comments)
File ch347_spi.c:
https://review.coreboot.org/c/flashrom/+/82776/comment/b1fbdcb0_836c1656?usp... : PS4, Line 56: speed
I think `divisor` might be a better term here, as the values passed to the CH347 divide the referenc […]
Very reasonable,done.
https://review.coreboot.org/c/flashrom/+/82776/comment/039973d3_fa9ec61b?usp... : PS4, Line 72: 0x0
There isn't really a need to write the speeds in hexadecimal, so just drop the `0x` prefix
Done
https://review.coreboot.org/c/flashrom/+/82776/comment/f767300f_0f78cde1?usp... : PS4, Line 287: defaulet
default
Done
https://review.coreboot.org/c/flashrom/+/82776/comment/65686b90_e5a75695?usp... : PS4, Line 287: 0x0
Just use decimal […]
For practicality, it has been modified to default to 30MHz,done.
https://review.coreboot.org/c/flashrom/+/82776/comment/49ddda37_f716cfe9?usp... : PS4, Line 365: M
I would use MHz for more clarity instead of just M
Done
https://review.coreboot.org/c/flashrom/+/82776/comment/bea8dc71_66d9b594?usp... : PS4, Line 365: defaul
default
Done
https://review.coreboot.org/c/flashrom/+/82776/comment/f8cc7857_69d06fba?usp... : PS4, Line 365: (60M clock spi)
I don't think the parenthesis really add any value here; I would just drop them.
Done